Skip to content

fix: validate that dask-style chunks have regular shapes#3779

Open
maxrjones wants to merge 3 commits intozarr-developers:mainfrom
maxrjones:variable-chunks-test
Open

fix: validate that dask-style chunks have regular shapes#3779
maxrjones wants to merge 3 commits intozarr-developers:mainfrom
maxrjones:variable-chunks-test

Conversation

@maxrjones
Copy link
Member

@maxrjones maxrjones commented Mar 13, 2026

This PR addresses a TODO in normalize_chunks to validate that dask-style chunks are regular. I think this is important to add before the rectilinear chunks feature to make sure that rectilinear-chunks can be explicitly opted in to. Previously, irregular chunks like ((10, 20, 30),) were silently coerced to (10,), producing a grid that didn't match the input specifications.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

dcherian
dcherian reviewed Mar 13, 2026
View reviewed changes
maxrjones and others added 2 commits March 13, 2026 15:16
@maxrjones @dcherian
Apply suggestion from @dcherian
293977e 
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
@maxrjones
Fix shortcircuit option
9ad42a6
@maxrjones maxrjones added the benchmark Code will be benchmarked in a CI job. label Mar 13, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 13, 2026

Merging this PR will not alter performance

✅ 66 untouched benchmarks
⏩ 6 skipped benchmarks1

Comparing maxrjones:variable-chunks-test (9ad42a6) with main (1bfa53f)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcherian dcherian dcherian left review comments

@d-v-b d-v-b d-v-b approved these changes

Assignees

No one assigned

Labels

benchmark Code will be benchmarked in a CI job.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxrjones @dcherian @d-v-b